New example to generate AST from scratch #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
requested changes
May 30, 2023
examples/generate_ast.py
Outdated
| # Andre Ribeiro [https://github.com/Andree37] | ||
| # License: BSD | ||
| # ----------------------------------------------------------------- | ||
| from __future__ import print_function |
There was a problem hiding this comment.
This is unnecessary now -- I also just removed it from other examples for consistency
examples/generate_ast.py
Outdated
| constant_zero = c_ast.Constant(type='int', value='0') | ||
| return_node = c_ast.Return(expr=constant_zero) | ||
| compound_node = c_ast.Compound(block_items=[return_node]) | ||
| type_decl_node = c_ast.TypeDecl(declname='main', quals=[], type=c_ast.IdentifierType(names=['int']), align=[]) |
There was a problem hiding this comment.
pycparser code typically tries to wrap at 80 columns
should be easy here with all the keyword params (like you do in func_def_node)
examples/generate_ast.py
Outdated
| # } | ||
|
|
||
|
|
||
| def create_your_ast(): |
There was a problem hiding this comment.
More descriptive name: maybe something like "empty_main_function_ast"
|
Corrected :) |
eliben
approved these changes
May 30, 2023
|
Some of the builders are failing - check out other examples to see how to set up the import path to work properly. |
I believe I have corrected it now, unless I also needed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was doing some research and I came along this
I found there was no example on how to create an AST from scratch and print out the target C code.
I purpose something of this sort as an initial example. As I am a beginner of the module, please don't be afraid to suggest changes :)