Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [scrollbar] switch to script-setup syntax #7986

Merged
merged 3 commits into from May 30, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented May 30, 2022

#6114

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented May 30, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 30, 2022
@holazz
Copy link
Member Author

holazz commented May 30, 2022

cc @sxzz

@github-actions
Copy link

github-actions bot commented May 30, 2022

🧪 Playground Preview: https://element-plus.run/?pr=7986
Please comment the example via this playground if needed.

@sxzz sxzz merged commit 54efcfb into element-plus:dev May 30, 2022
@holazz holazz deleted the refactor/scrollbar_script-setup branch May 31, 2022 00:10
@sxzz

This comment was marked as resolved.

@holazz
Copy link
Member Author

holazz commented May 31, 2022

element-plus/element-plus/runs/6662396264?check_suite_focus=true

Could you please check this?

Update: never mind

I'm debugging, it seems to be caused by removing scrollbar from type-unsafe, I don't need to care about this now?

@tolking
Copy link
Member

tolking commented Jun 1, 2022

I found that the table header does not scroll with the body, maybe the Scrollbar components should expose more values.

eq: scrollbar$, wrap$, resize$ ...

@holazz
Copy link
Member Author

holazz commented Jun 1, 2022

I found that the table header does not scroll with the body, maybe the Scrollbar components should expose more values.

eq: scrollbar, resize$ ...

I found that wrap$ is used in table, I fixed it here #8035

This was referenced Jun 4, 2022
@sxzz sxzz mentioned this pull request Jun 20, 2022
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants