Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix ci image/avatar test error #16863

Merged
merged 12 commits into from
May 16, 2024
Merged

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 15, 2024

dev: test

Edit Before: dev test*70 ✅

image

Edit After: Same Edit Before ✅

github ci: test

Edit before: probabilistic occurrence (Is the node version affected?) ❗

#16860 (comment)

image

Edit After:

Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented May 15, 2024

Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented May 15, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16863
Please comment the example via this playground if needed.

@warmthsea
Copy link
Contributor Author

@btea
Please ask a question, how can I execute ci unit-test again without changing the code?

@warmthsea
Copy link
Contributor Author

new test error avatar

image

@warmthsea warmthsea changed the title test: fix ci image test error test: fix ci image/avatar test error May 15, 2024
@btea
Copy link
Collaborator

btea commented May 15, 2024

@btea Please ask a question, how can I execute ci unit-test again without changing the code?

Generally, it will only be run when the code is updated, or the project team members can help click re-run.
Regarding the test case you modified, it sometimes fails, but it should be related to the environment, so there is no need to modify it, just rerun it.

@warmthsea
Copy link
Contributor Author

I only changed the test errors that I encountered with a high probability. (CI)

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran several tests and everything seemed to be normal. We can merge this PR first and see if there will be no errors in the future.

@btea btea merged commit 48e75f5 into element-plus:dev May 16, 2024
9 checks passed
@warmthsea warmthsea deleted the fix/image-test branch May 16, 2024 04:51
@warmthsea warmthsea restored the fix/image-test branch May 16, 2024 04:51
@warmthsea
Copy link
Contributor Author

I ran several tests and everything seemed to be normal. We can merge this PR first and see if there will be no errors in the future.

I added 25 duplicate CIs for testing, and 1 or 2 errors occurred each time.

screenshots

@btea
Copy link
Collaborator

btea commented May 16, 2024

I looked at some of the error conditions, and it seems that they are not a problem with the use case, but an internal problem with jsdom. This random situation can be ignored.

@warmthsea
Copy link
Contributor Author

I looked at some of the error conditions, and it seems that they are not a problem with the use case, but an internal problem with jsdom. This random situation can be ignored.

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants