Update eslint rules #1039
Open
Update eslint rules #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 18, 2023 20:27
|
I also suggest you to consider adding object-curly-spacing rule to the ESLint configuration, I left it as it, because I'm not sure on the appropriate values for this rule. |
sleroq
commented
Feb 18, 2023
Comment on lines
+28
to
+30
| // "@typescript-eslint/no-misused-promises": "error", | ||
| // "@typescript-eslint/no-floating-promises": 2, | ||
| // "@typescript-eslint/explicit-function-return-type": "error" |
There was a problem hiding this comment.
Rather than taking the to resolve the warnings, I opted to disable this rules for now.
|
no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed some inconsistencies in the code, which is why I am proposing an update to the ESLint configuration.
In this merge request, I removed
.ts-eslintrc.jsand added new rules to main eslint config.I picked values are based on what gives fewer warnings and what we had in the past, so this may not be the best for each situation; however, this should provide a good starting point as far as making sure coding practices are consistent across all files.
That being said, I don't want to force anything upon anyone else working on this project - if you feel like some of these rules need changing or removing, then let's discuss it, so we can come up with something everyone agrees upon
I would appreciate any feedback before merging my request into master branch if possible!