Theme Options in User Settings Are Mildly Broken

[tessgadwa]

Description

After switching between theme options using the radio buttons in User Settings, switching back to the previous selection has no effect.

Steps to reproduce

• Switch from Light theme to Dark theme
• Without closing the User Settings window, switch back from Dark theme to Light theme

The theme will remain Dark.

If you close the User Settings window and reopen, you are then able to select the radio button for the theme of your choice.

Log: sent

Version information

• Platform: web

For the web app:

• Browser: Chrome 59.0.3
• OS: macOS
• URL: https://riot.im/app

[turt2live]

Confirmed also broken on riot.im/develop

[tessgadwa]

This is only a minor glitch in everyday use, but becomes more problematic when >2 theme options are included under User Settings.

[lampholder]

When trying to reproduce this, I had a slightly different failure mode.

I had Riot logged in on two machines (side by side). Toggling from light to dark on machine A, the change actually occurred on machine B. Machine A did not change it's theme.

Toggling from dark back to light as described in the original report had no effect.

[t3chguy]

note to self, onChange is only firing the first time

[t3chguy]

was fine in v0.10.2

[t3chguy]

It seems like it was broken by an unpinned React dep
(and them fixing an implicit bug)

[t3chguy]

React 15.6.0 introduced facebook/react#8575 which broke the theme selector

[turt2live]

This has been fixed.