Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testnet and Stagenet chain configurations; Minor bug fixes; Removed unused consensus; Update Go package refs #3

Merged
merged 30 commits into from Jun 28, 2022
Merged

Testnet and Stagenet chain configurations; Minor bug fixes; Removed unused consensus; Update Go package refs #3

merged 30 commits into from Jun 28, 2022

Conversation

andrepatta
Copy link
Member

@andrepatta andrepatta commented Jun 27, 2022 •
edited

This PR includes the following changes.

Chain config:

  • New chain configuration for test network (--testnet) with pre-allocated funds
  • New chain configuration for stage network (--stagenet) with pre-allocated funds

Consensus:

  • Removed unused standard IBFT consensus
  • Renamed and moved modified version of IBFT (QBFT) to consensus/istanbul
  • Removed the ability to customize some IBFT settings through startup flags and/or custom genesis
  • Make sure we always use Ceil(2N/3) for consensus messages

Binaries:

  • Renamed geth to etn-sc
  • Renamed ethkey to etnkey
  • Properly set version in params/version.go
  • Update Dockerfile entrypoint

Default Data Dir:

  • Mainnet default root dir changed from ~/.ethereum to ~/.electroneum-sc
  • Mainnet default data dir changed from ~/.ethereum/geth to ~/.electroneum-sc/etn-sc
  • Stagenet default root dir set to ~/.electroneum-sc/stagenet
  • Stagenet default data dir set to ~/.electroneum-sc/stagenet/etn-sc
  • Testnet default root dir set to ~/.electroneum-sc/testnet
  • Testnet default data dir set to ~/.electroneum-sc/testnet/etn-sc

Fixes:

  • Make sure we don't wait 7 blocks to set it as canonical if using IBFT (because of 1BF)
  • Fixed an issue where a validator could provide any coinbase address for block rewards
  • Make sure we don't use DNS peer-finding for now (needs further setup)
  • Updated some missing NetworkId entries that were still using the old value (1 -> 52014)
  • Fixed an issue where BootstrapNodes weren't properly set (from config.toml) when running geth with a test network flag (also PR'd to go-ethereum cmd/utils: fix applying bootstrap nodes from config file ethereum/go-ethereum#25174 (comment))

Other:

  • Renamed all ethereum/go-ethereum Go package references to electroneum/electroneum-sc

@andrepatta
geth/core/params: add startup arg for Electroneum's mainnet and testnet
33433b6
@andrepatta
node: change default data dir
f776e66
@andrepatta
qbft: check if coinbase address corresponds with block signer
c320d45
@andrepatta
cmd/core/eth/mobile/params: Remove eth testnets and add Electroneum's…
2d176a3 
… mainnet/testnet configs

Electroneum mainnet chainId: 52014 (A1Z26 cipher for "ETN")
Electroneum testnet chainId: 5201420 (A1Z26 cipher for "ETNT")
@andrepatta
consensus/eth/params: always use Ceil2Nby3 for istanbul consensus mes…
165834b 
…sages
@andrepatta
cmd/core/eth/miner/params: remove IsQuorum chain configuration flag
8d2a05c
@andrepatta
consensus/eth/params: remove TestQBFTBlock from chain configuration
948787f 
(always use QBFT instead of standard IBFT)
@andrepatta
consensus/eth/params: remove standard IBFT consensus engine
3495451 
(keep the modified QBFT one)
@andrepatta
cmd/consensus/core/eth/miner/params: replace QBFT with IBFT chain con…
910c431 
…fig (name), remove "Istanbul" chain config

Plus some house keeping
@andrepatta
miner: instantly make block canonical if using IBFT consensus
13f75cd
@andrepatta
core: update testnet genesis with validator addresses
b1642fb
@andrepatta
core: update testnet genesis with correct timestamp
b8b6ab8
@andrepatta
params: update testnet genesis hash
740563e
@andrepatta
cmd: update geth/cmd tests with the new testnet genesis timestamp
58ff524
@andrepatta
cmd/core/mobile/params: add support for stagenet chain configuration
327c86c
@andrepatta
core/params: pre-alloc funds in testnet and stagenet
ea1f129
@andrepatta
params: don't use DNS to fetch peers for now, need to setup etn dns f…
2f0ff4d 
…irst
@andrepatta
cmd/les/mobile: set missing networkids to the correct value
5fc1b6f
@andrepatta
cmd: fix custom bootstrap nodes for testnet and stagenet
0e0db41
@andrepatta
params: comment out unused dnsPrefix variable
83d39ea 
makes lint happy :)
@andrepatta
params/version: set etn version
790f502
@andrepatta
cmd/ethkey: rename ethkey to etnkey
eed2b31
@andrepatta
cmd/geth: rename geth to etn-sc
3ed05c1
@andrepatta andrepatta marked this pull request as ready for review June 27, 2022 23:07
@andrepatta andrepatta self-assigned this Jun 27, 2022
@andrepatta andrepatta changed the title Testnet and Stagenet chain configurations Testnet and Stagenet chain configurations; Minor bug fixes; Removed unused consensus; Update Go package refs Jun 28, 2022
@andrepatta andrepatta merged commit 2409292 into master Jun 28, 2022
chrischarlesharrison added a commit that referenced this pull request Dec 18, 2023
@chrischarlesharrison
SC reset #3 after oracle changes
492484f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthur-ngdi arthur-ngdi Awaiting requested review from arthur-ngdi

@electroneumRepo electroneumRepo Awaiting requested review from electroneumRepo

@MatheusJulidori MatheusJulidori Awaiting requested review from MatheusJulidori

Assignees

@andrepatta andrepatta

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andrepatta