fix: labels when trop PR closed unmerged #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaurencin
force-pushed
the
fix-trop-close-labeling
branch
from
2a33e49
to
8bebd9f
Compare
ckerr
reviewed
Oct 22, 2020
mlaurencin
force-pushed
the
fix-trop-close-labeling
branch
from
8bebd9f
to
400b0e9
Compare
codebytere
requested changes
Oct 22, 2020
codebytere
approved these changes
Oct 22, 2020
ckerr
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
Previously when trop backport was closed, trop would keep the in-flight label rather than removing it. This was occurring because we were lacking logic to handle non-manual backport being closed with unmerged commits.
cc @codebytere