Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: invalid backports are neutral instead of failure #146

Closed
wants to merge 1 commit into from
Closed

feat: invalid backports are neutral instead of failure #146

wants to merge 1 commit into from

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Apr 3, 2020

Marking the build failed because it's missing a backport annotation obscures the CI status in the PR list, and there are many valid reasons to have PRs targeting non-master branches that aren't direct backports.

Most recently: electron/electron#22943

@nornagon nornagon requested a review from a team as a code owner April 3, 2020 00:26
codebytere
codebytere reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nornagon i'd prefer i think to leave this as failure - i introduced a label to work around this specific case recently here: #137

which i think might be a more appropriate solution to the problem you were facing in the above PR?

@codebytere codebytere closed this Apr 23, 2020
@codebytere
Copy link
Member

(Closing as we are using the label now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @codebytere