fix(template-webpack): only run asset relocator loader on node_modules folder
#3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
approved these changes
Nov 9, 2022
|
wfm locally, waiting for ci to pass before merging |
erickzhao
changed the title
node_modules folder
VerteDinde
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3055
The reason this plugin does this is long and complicated but it's easy to just not run the plugin on app-code and limit it to
node_modules. If you have node_modules code that does this pattern of assuming webpack will make the worker (a) that's weird and (b) you can just exclude that module in a similar way.This should fix it by default for like 99% of folks though.