Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not proxify class instances in forge config #3039

Merged
merged 2 commits into from
Nov 1, 2022
Merged

fix: do not proxify class instances in forge config #3039

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7331860
fix: do not proxify class instances in forge config
MarshallOfSound Nov 1, 2022
decccc9
spec: fix config tests
MarshallOfSound Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api/core/src/util/forge-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const proxify = <T extends ProxiedObject>(buildIdentifier: string | (() => strin
}

for (const [key, val] of Object.entries(proxifiedObject)) {
if (typeof val === 'object' && key !== 'pluginInterface' && !(val instanceof RegExp)) {
if (typeof val === 'object' && val.constructor === Object && key !== 'pluginInterface' && !(val instanceof RegExp)) {
(newObject as any)[key] = proxify(buildIdentifier, (proxifiedObject as any)[key], `${envPrefix}_${underscoreCase(key)}`);
} else {
(newObject as any)[key] = (proxifiedObject as any)[key];
Expand Down