New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(publisher-ers): support customizable artifact extensions #2220
Draft
nullxx
wants to merge
27
commits into
electron:main
Choose a base branch
from
nullxx:master
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullxx
changed the title
Customizable artifacts extensions electron-release-server
feat: Customizable artifacts extensions electron-release-server
Apr 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #2220 +/- ##
==========================================
- Coverage 72.66% 72.15% -0.52%
==========================================
Files 74 74
Lines 2221 2237 +16
Branches 420 427 +7
==========================================
Hits 1614 1614
- Misses 448 464 +16
Partials 159 159
Continue to review full report at Codecov.
|
5 tasks
…on#2585) When making with windows.squirrel and the noDelta options selected, the delta package will end up in the artifacts list and kill the publishing phase. Although unrelated, this will only publish files that are actually on disk at the time of publishing. Co-authored-by: Tom Van Damme <tom.vandamme@two-point-o.be>
erickzhao
changed the title
feat: Customizable artifacts extensions electron-release-server
feat(publisher-ers): support customizable artifact extensions
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Now, when using publisher
electron-release-server
you can select the file extensions of the artifacts to upload.This is configurable.
Fixes ArekSredzki/electron-release-server#239