Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher-ers): support customizable artifact extensions #2220

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

nullxx
Copy link

@nullxx nullxx commented Apr 6, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Now, when using publisher electron-release-server you can select the file extensions of the artifacts to upload.
This is configurable.

Fixes ArekSredzki/electron-release-server#239

@nullxx nullxx changed the title Customizable artifacts extensions electron-release-server feat: Customizable artifacts extensions electron-release-server Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2220 (936fab5) into master (e1c218c) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
- Coverage   72.66%   72.15%   -0.52%     
==========================================
  Files          74       74              
  Lines        2221     2237      +16     
  Branches      420      427       +7     
==========================================
  Hits         1614     1614              
- Misses        448      464      +16     
  Partials      159      159              
Impacted Files Coverage Δ
...lisher/electron-release-server/src/PublisherERS.ts 21.95% <0.00%> (-5.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c218c...936fab5. Read the comment docs.

@erickzhao erickzhao marked this pull request as draft November 8, 2022 23:04
@erickzhao erickzhao changed the title feat: Customizable artifacts extensions electron-release-server feat(publisher-ers): support customizable artifact extensions Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish fails after upgrade of @electron-forge/publisher-electron-release-server
4 participants