New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use InvalidateLayout() not DeprecatedLayoutImmediately() #41899
Draft
ckerr
wants to merge
1
commit into
main
Choose a base branch
from
refactor/use-InvalidateLayout-not-DeprecatedLayoutImmediately
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: use InvalidateLayout() not DeprecatedLayoutImmediately() #41899
ckerr
wants to merge
1
commit into
main
from
refactor/use-InvalidateLayout-not-DeprecatedLayoutImmediately
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasting CI failures here as breadcrumbs. In order of likely to unlikely, these CI failures may be that the tests were coded to assume synchronous operations, or that this PR really is introducing new bugs, or maybe they're all CI flakes 😜
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Replace our calls to the deprecated API
DeprecatedLayoutImmediately()
withInvalidateLayout()
instead.It looks like all of the occurrences were just to trigger a new draw & didn't necessarily rely on it happening immediately, so
InvalidateLayout()
is the call preferred by upstream.Xref: https://crbug.com/1121681
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5242027
Checklist
npm test
passesRelease Notes
Notes: none