feat: add cumulativeCPUUsage to AppMetrics and CPUUsage #41819
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
rcombs
force-pushed
the
cumulativeCPUUsage
branch
from
3e93a90
to
ac3d74f
Compare
nornagon
reviewed
Apr 10, 2024
rcombs
force-pushed
the
cumulativeCPUUsage
branch
4 times, most recently
from
dfe3d4e
to
80c045f
Compare
ckerr
reviewed
Apr 15, 2024
rcombs
force-pushed
the
cumulativeCPUUsage
branch
from
80c045f
to
ac98b04
Compare
|
API LGTM |
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
@rcombs can you rebase and fix conflicts? |
This allows apps to measure their CPU usage over any given period without worrying about other calls affecting the output, as they would with `percentCPUUsage`.
rcombs
force-pushed
the
cumulativeCPUUsage
branch
from
ac98b04
to
39d04bf
Compare
electron-cation
bot
added
api-review/requested 🗳
and removed
api-review/approved ✅
labels
| cpu_dict.Set("percentCPUUsage", usage / processor_count); | ||
| // Default usage percentage to 0 for compatibility | ||
| double usagePercent = 0; | ||
| if (auto usage = process_metric.second->metrics->GetCumulativeCPUUsage()) { |
There was a problem hiding this comment.
This needs to use the base::TimeDelta value. A gin converter (see time_converter.cc) might need to be added for the JS binding, if it's not set as a primitive type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This allows apps to measure their CPU usage over any given period without worrying about other calls affecting the output, as they would with
percentCPUUsage.Checklist
npm testpassesHaven't run the tests because I couldn't get the build process to cooperate locally, but this worked fine and returned results in line with expectations on a CI build I ran.
Release Notes
Notes: Added
cumulativeCPUUsageto AppMetrics and CPUUsage