fix: silent printing default dpi on Windows #41811
Merged
+185
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-silent-print-dpi-win
branch
2 times, most recently
from
dc34139
to
ea727b5
Compare
This was referenced Apr 10, 2024
codebytere
force-pushed
the
fix-silent-print-dpi-win
branch
from
ea727b5
to
30979b6
Compare
codebytere
force-pushed
the
fix-silent-print-dpi-win
branch
from
30979b6
to
0426abf
Compare
jkleinsc
approved these changes
Apr 11, 2024
|
Release Notes Persisted
|
This was referenced Apr 11, 2024
|
I have automatically backported this PR to "29-x-y", please check out #41836 |
trop
bot
added
in-flight/29-x-y
and removed
target/29-x-y
|
I have automatically backported this PR to "28-x-y", please check out #41837 |
|
I have automatically backported this PR to "30-x-y", please check out #41838 |
trop
bot
removed
the
target/28-x-y
trop
bot
added
in-flight/30-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #39179.
Closes #40714.
Fixes an issue on Windows where silent printing resulted in comically tiny renderer output unless the dpi was overridden on the user side. This is fixed by pulling the dpi before calling print and using the printer default unless it's been explicitly overridden by the user. This PR also pulls printing utility functions into a new folder for cleanliness and simplicity.
Tested with https://gist.github.com/053de2471f74277e60fb908aaa3685ff
PDF Sample Before
PDF Sample After
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue on Windows where silent printing resulted in comically tiny renderer output.