New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix notes stack updates #41600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
Yes, I will work on adding a unit test next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test(s) should be added before we merge this.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
fb2d60b
to
744dad6
Compare
No Release Notes |
Description of Change
This PR fixes an issue that would appear when there were multiple Chromium stack upgrades between versions. The notes script did not correctly handle the comparisons needed to determine which stack upgrade superceded which. An example of the previous issue can be seen here: https://github.com/electron/electron/releases/tag/v29.1.1 lists Chromium 122.0.6261.95, however according to https://github.com/electron/electron/blob/v29.1.1/DEPS it's 122.0.6261.111.
Checklist
npm test
passesRelease Notes
Notes: None