Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: browserView.webContents can be null #40569

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+4 −2
Open

docs: browserView.webContents can be null #40569

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
74ecec1
Add `null` as type for `browserView.webContents`
Juice10 Nov 20, 2023
cdc77e0
Update docs/api/browser-view.md
Juice10 Nov 20, 2023
f66d20c
Bring `webContents` in line with `fromWebContents` in BrowserWindow
Juice10 Nov 20, 2023
1c6f400
Fix typo
Juice10 Nov 20, 2023
c176058
Remove redundant documentation
Juice10 Nov 23, 2023
178a6c1
Update browser-view.md
Juice10 Nov 23, 2023
688682c
Update docs/api/browser-view.md
Juice10 Nov 28, 2023
b57d411
Update docs/api/browser-view.md
Juice10 Dec 4, 2023
16e636d
BrowserWindow.fromBrowserView can return null
Juice10 Dec 11, 2023
5e62964
Refactor BrowserWindow.fromBrowserView
Juice10 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/browser-view.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Objects created with `new BrowserView` have the following properties:

#### `view.webContents` _Experimental_

A [`WebContents`](web-contents.md) object owned by this view.
A `WebContents | null` property that returns the `WebContents` owned by this view or `null` if the contents are [destroyed](web-contents.md#event-destroyed).
codebytere marked this conversation as resolved.
Show resolved Hide resolved
Juice10 marked this conversation as resolved.
Show resolved Hide resolved

### Instance Methods

Expand Down