chore: restore deprecate as an internal module #40124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/restore-deprecate-module
branch
from
872bb65
to
8d36be2
Compare
3 tasks
miniak
force-pushed
the
miniak/restore-deprecate-module
branch
3 times, most recently
from
eaf4ea0
to
1070697
Compare
This reverts commit 8424779.
miniak
force-pushed
the
miniak/restore-deprecate-module
branch
from
1070697
to
2de66c4
Compare
miniak
force-pushed
the
miniak/restore-deprecate-module
branch
from
2de66c4
to
9d09ef0
Compare
zcbenz
approved these changes
Oct 8, 2023
|
No Release Notes |
|
/trop run backport-to 27-x-y |
|
The backport process for this PR has been manually initiated - sending your PR to |
|
I was unable to backport this PR to "27-x-y" cleanly; |
jkleinsc
pushed a commit
that referenced
this pull request
Oct 10, 2023
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
* Revert "refactor: don't expose deprecate as an internal module (electron#35311)" This reverts commit 8424779. * check crashed event warnings
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Revert "chore: restore deprecate as an internal module (electron#40124)" This reverts commit 737e3de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #35311 as it prevents us from testing deprecation warnings as the tests contain a different copy of the deprecate module than Electron itself
Also add missing tests for deprecated event warnings to unblock #40089
Notes: none