Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix Appveyor test workflow checkout #39137

Merged
merged 3 commits into from Jul 20, 2023
Merged

build: fix Appveyor test workflow checkout #39137

merged 3 commits into from Jul 20, 2023

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 18, 2023 •
edited

Description of Change

Fixes an issue where Appveyor will checkout main for test builds, which causes failures if the branch at hand has not been rebased to contain fixes necessary for new tests to pass. Below is a sample failure that occurred on the roll branch, because #38754 was merged, and the new test was checked out on the roll and run despite the branch build not containing the associated source changes.

Example

Screenshot 2023-07-18 at 2 07 24 PM

Checklist

Release Notes

Notes: none

@codebytere codebytere marked this pull request as ready for review July 19, 2023 15:23
@codebytere codebytere added target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Jul 20, 2023
@codebytere codebytere merged commit 6688b0f into main Jul 20, 2023
17 checks passed
@codebytere codebytere deleted the fix-appveyor-test-checkout branch July 20, 2023 09:19
@release-clerk
Copy link

release-clerk bot commented Jul 20, 2023

No Release Notes

This was referenced Jul 20, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 20, 2023

I have automatically backported this PR to "24-x-y", please check out #39169

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Jul 20, 2023
@trop trop bot mentioned this pull request Jul 20, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Jul 20, 2023

I have automatically backported this PR to "26-x-y", please check out #39170

@trop
Copy link
Contributor

trop bot commented Jul 20, 2023

I have automatically backported this PR to "25-x-y", please check out #39171

@trop trop bot added in-flight/25-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. in-flight/24-x-y in-flight/25-x-y labels Jul 20, 2023
@trop trop bot removed the in-flight/26-x-y label Jul 20, 2023
@commit-lint commit-lint bot mentioned this pull request Sep 28, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
build: fix Appveyor test workflow checkout (electron#39137)
f5aa551 
* build: fix Appveyor test workflow checkout

* fix: +refs/pull/num/merge -> +refs/pull/num/head

* chore: add to appveyor-woa as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/24-x-y PR was merged to the "24-x-y" branch merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @VerteDinde