fix: child window may have opener removed #38910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
semver/patch
ckerr
approved these changes
Jun 23, 2023
codebytere
approved these changes
Jun 23, 2023
jkleinsc
approved these changes
Jun 26, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "26-x-y", please check out #38930 |
trop
bot
removed
the
target/26-x-y
|
I have automatically backported this PR to "25-x-y", please check out #38931 |
|
I have automatically backported this PR to "24-x-y", please check out #38932 |
|
I have automatically backported this PR to "23-x-y", please check out #38933 |
trop
bot
added
in-flight/25-x-y
in-flight/24-x-y
and removed
target/25-x-y
trop
bot
added
merged/25-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When handling node integration in child windows opened by
window.open, the code assumed the child window's web frame must have aopener, which is not correct since theopenermay be set to null.Close #38844.
Checklist
npm testpassesRelease Notes
Notes: Fix
preloadscript may not run in some child windows opened bywindow.open.