Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abort ShipIt installation attempt at the final mile if the app is running #37794

Merged
merged 2 commits into from Apr 3, 2023

Conversation

VerteDinde
Copy link
Member

Manual backport of #36130

See that PR for details

Notes: Fixed race condition during update on macOS that could result in TCC and Keychain errors

…s running (#36130)

* fix: abort ShipIt installation attempt at the final mile if the app is running

* chore: remove only

* Update patches/squirrel.mac/fix_abort_installation_attempt_at_the_final_mile_if_the_app_is.patch

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

* chore: update patches

* spec: make the ShipIt process lister helper more resilient

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@VerteDinde VerteDinde requested review from a team as code owners April 2, 2023 19:34
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 2, 2023
@trop trop bot added 21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 2, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 2, 2023
@codebytere codebytere merged commit 105e58f into 21-x-y Apr 3, 2023
9 checks passed
@codebytere codebytere deleted the mp-shipit-final-mile-21-x-y branch April 3, 2023 10:40
@release-clerk
Copy link

release-clerk bot commented Apr 3, 2023

Release Notes Persisted

Fixed race condition during update on macOS that could result in TCC and Keychain errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
21-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants