-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash on WebWorkerObserver
script execution
#37081
fix: crash on WebWorkerObserver
script execution
#37081
Conversation
Hi @codebytere |
Hello @codebytere ! I noticed the tests seem to fail. Could we be of any help here? |
This seems to actually be a different failure than the original one fixed in this PR:
it also happens without these changes, leading me to believe this is also a function of different Node.js versions between 23 and main. |
Oh ok, makes sense now! Out of curiosity, would there be a way for us to test these changes in the meantime? |
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
6ca2ec9
to
fb39bed
Compare
The checks SUCCEEDED 🎉 |
Release Notes Persisted
|
Backport of #37050
See that PR for details.
Notes: Fixed a potential crash in some types of Worklets.