Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated capturer count APIs #37075

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 30, 2023

Description of Change

Follow-up to #35710. This is already documented:

Checklist

Release Notes

Notes: The deprecated incrementCapturerCount() / decrementCapturerCount() methods have been removed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 30, 2023
@miniak miniak self-assigned this Jan 30, 2023
@miniak miniak added semver/major incompatible API changes target/23-x-y PR should also be added to the "23-x-y" branch. labels Jan 30, 2023
@nornagon
Copy link
Member

API LGTM

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak miniak changed the title chore: remove deprecated incrementCapturerCount() / decrementCapturerCount() chore: remove deprecated capturer count APIs Jan 30, 2023
@codebytere
Copy link
Member

API LGTM

Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@VerteDinde VerteDinde merged commit 8d382b9 into main Feb 6, 2023
@VerteDinde VerteDinde deleted the miniak/remove-capturer-count-apis branch February 6, 2023 15:54
@release-clerk
Copy link

release-clerk bot commented Feb 6, 2023

Release Notes Persisted

The deprecated incrementCapturerCount() / decrementCapturerCount() methods have been removed.

@trop
Copy link
Contributor

trop bot commented Feb 6, 2023

I have automatically backported this PR to "23-x-y", please check out #37148

@trop trop bot added in-flight/23-x-y merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. in-flight/23-x-y labels Feb 6, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
chore: remove deprecated incrementCapturerCount() / decrementCapturerCount()

Co-authored-by: Milan Burda <miburda@microsoft.com>
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
chore: remove deprecated incrementCapturerCount() / decrementCapturerCount()

Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review/requested 🗳 merged/23-x-y PR was merged to the "23-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/major incompatible API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants