fix: re-enable WindowCaptureMacV2 #37014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
re-enable-WindowCaptureMacV2
branch
from
2af42ae
to
24c7f1e
Compare
|
Test failures are related. |
ckerr
reviewed
Jan 25, 2023
deepak1556
reviewed
Jan 26, 2023
| // TODO(deepak1556): Match upstream for `kWindowCaptureMacV2` | ||
| #if 0 | ||
| if (remote_cocoa::ScopedCGWindowID::Get(desktop_media_id.id)) { | ||
| desktop_media_id.window_id = desktop_media_id.id; |
There was a problem hiding this comment.
Is this change not needed with the feature enabled ? https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/media/webrtc/native_desktop_media_list.cc;l=770
There was a problem hiding this comment.
@deepak1556 we could do this, but then it would be invalid when for example passed into getUserMedia. I made this change for the same reason i did this one: https://github.com/electron/electron/pull/37014/files#diff-73f755a575b1c517f40cd8358386c43c4ffb0eff9e8a7a9ab80c5f50a248dcf4R156
codebytere
force-pushed
the
re-enable-WindowCaptureMacV2
branch
from
b0af853
to
b227598
Compare
github-actions
bot
added
the
target/26-x-y
codebytere
force-pushed
the
re-enable-WindowCaptureMacV2
branch
from
d9d2a22
to
4c6abd3
Compare
github-actions
bot
added
the
target/27-x-y
miniak
removed
target/23-x-y
github-actions
bot
added
the
target/28-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #30507.
Per upstream CRBUG:1179098, issues have been fixed and is no longer reproducible when testing with https://gist.github.com/925744c7c67347d67c5b29e91c31e37e .
Checklist
npm testpassesRelease Notes
Notes: none