Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable crashpad for ELECTRON_RUN_AS_NODE processes #36483

Merged
merged 2 commits into from Nov 29, 2022

Commits on Nov 29, 2022

  1. fix: enable crashpad for ELECTRON_RUN_AS_NODE processes

    * wip: enable crashpad for node processes
    
    fix: add PID testing method
    
    wip: plumb fd into child_process in node
    
    * node::ProcessInitializationFlags::kNoDefaultSignalHandling
    
    * chore: clean up debug logging
    
    * chore: gate platform includes
    
    * test: clean up node process test
    
    * fix: pass pid in node_main
    
    * chore: cleanup impl
    
    * chore: fixup patch method definition
    
    * fix: expose bound methods to node_main
    
    * fix: remove bound methods
    
    * fix: crashpad connection for all ELECTRON_RUN_AS_NODE processes
    
    * chore: fix typo
    
    * chore: address review feedback
    
    * chore: delay crashpad initialization
    
    * chore: ensure options.env, code hygiene
    
    * chore: add argv test, check for process.env over {}
    
    * fix: fix test, return options.env immutability
    
    Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
    Co-authored-by: Jeremy Rose <jeremya@chromium.org>
    Co-authored-by: VerteDinde <vertedinde@electronjs.org>
    3 people committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    6ac31ee View commit details
    Browse the repository at this point in the history
  2. chore: update patches

    patchup[bot] committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0609f0c View commit details
    Browse the repository at this point in the history