Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable crashpad for ELECTRON_RUN_AS_NODE processes #36460

Merged
merged 17 commits into from
Nov 29, 2022
Merged

fix: enable crashpad for ELECTRON_RUN_AS_NODE processes #36460

merged 17 commits into from
Nov 29, 2022

Commits on Nov 24, 2022

  1. wip: enable crashpad for node processes 

    fix: add PID testing method

wip: plumb fd into child_process in node
    @VerteDinde
    VerteDinde committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    a177d0d View commit details
    Browse the repository at this point in the history

  2. node::ProcessInitializationFlags::kNoDefaultSignalHandling

    @nornagon @VerteDinde
    nornagon authored and VerteDinde committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    5d263b0 View commit details
    Browse the repository at this point in the history

  3. chore: clean up debug logging

    @VerteDinde
    VerteDinde committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    bae57a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. chore: gate platform includes

    @VerteDinde
    VerteDinde committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    2626021 View commit details
    Browse the repository at this point in the history

  2. test: clean up node process test

    @VerteDinde
    VerteDinde committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    530fdfb View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. fix: pass pid in node_main

    @VerteDinde
    VerteDinde committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ad4f0d4 View commit details
    Browse the repository at this point in the history

  2. chore: cleanup impl

    @deepak1556
    deepak1556 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    49e1519 View commit details
    Browse the repository at this point in the history

  3. chore: fixup patch method definition

    @VerteDinde
    VerteDinde committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    cd77422 View commit details
    Browse the repository at this point in the history

  4. fix: expose bound methods to node_main

    @VerteDinde
    VerteDinde committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ac8b23f View commit details
    Browse the repository at this point in the history

  5. fix: remove bound methods

    @VerteDinde
    VerteDinde committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f644a62 View commit details
    Browse the repository at this point in the history

  6. fix: crashpad connection for all ELECTRON_RUN_AS_NODE processes

    @deepak1556
    deepak1556 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d00181c View commit details
    Browse the repository at this point in the history

  7. chore: fix typo

    @deepak1556
    deepak1556 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1665dd5 View commit details
    Browse the repository at this point in the history

  8. chore: address review feedback

    @deepak1556
    deepak1556 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    21b0e1f View commit details
    Browse the repository at this point in the history

  9. chore: delay crashpad initialization

    @deepak1556
    deepak1556 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    be15662 View commit details
    Browse the repository at this point in the history

  10. chore: ensure options.env, code hygiene

    @VerteDinde
    VerteDinde committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ecd98e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. chore: add argv test, check for process.env over {}

    @VerteDinde
    VerteDinde committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9463804 View commit details
    Browse the repository at this point in the history

  2. fix: fix test, return options.env immutability

    @VerteDinde
    VerteDinde committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d0e268c View commit details
    Browse the repository at this point in the history