chore: drop support for Windows 7 / 8 / 8.1 #36427

miniak · 2022-11-22T20:37:48Z

Description of Change

https://support.google.com/chrome/thread/185534985/sunsetting-support-for-windows-7-8-8-1-in-early-2023?hl=en
https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice

Closes #35597

Checklist

PR description included and stakeholders cc'd
npm test passes
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Windows 7, Windows 8, and Windows 8.1 are not supported anymore as Chromium 110 dropped support.

nornagon

Needs an update to breaking-changes.md and a blog post, I think!

miniak · 2022-11-22T20:54:28Z

Needs an update to breaking-changes.md and a blog post, I think!

@nornagon I will do that. How would you formulate it?

docs/breaking-changes.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

VerteDinde

Left one nit comment, but otherwise looks good!

docs/breaking-changes.md

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

nornagon

Let's also plan to write a blog post about this. cc @erickzhao and @electron/wg-ecosystem more generally

README.md

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

README.md

nornagon

let's update this with a link to our blog post once we have it. electron/website#319

miniak · 2022-11-30T20:28:18Z

@nornagon the blog post is up https://www.electronjs.org/blog/windows-7-to-8-1-deprecation-notice. Should I replace the Chromium support links with this one? Or keep both?

README.md

docs/breaking-changes.md

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

release-clerk · 2022-12-01T01:13:32Z

Release Notes Persisted

Windows 7, Windows 8, and Windows 8.1 are not supported anymore as Chromium 110 dropped support.

trop · 2022-12-01T01:14:11Z

I have automatically backported this PR to "23-x-y", please check out #36513

GitMensch · 2022-12-01T07:57:39Z

What does this mean for Windows Server 2012 R2 ?

pushkin- · 2022-12-15T22:28:42Z

@nornagon @miniak Can you confirm my assumption that Electron 23+ still run on Windows Server 2012 R2 after the loss of support, but it just won't get patches and might run into issues down the line.

CommonLoon102 · 2023-01-11T06:41:54Z

@nornagon @miniak Can you confirm my assumption that Electron 23+ still run on Windows Server 2012 R2 after the loss of support, but it just won't get patches and might run into issues down the line.

Windows Server was never mentioned in the README.md as a supported OS.

miniak · 2023-01-23T21:53:18Z

Windows Server 2012 R2 is actually the same as Windows 8.1 and I can confirm that Electron 23 no longer works there most likely due to changes in Chromium.

miniak · 2023-01-23T22:14:13Z

v23.0.0-alpha.1 (Chromium 110.0.5415.0) still runs on Windows 8.1
v23.0.0-alpha.2 (Chromium 110.0.5451.0) crashes on Windows 8.1

miniak · 2023-01-23T22:16:31Z

There is an issue tracking this #36909, let's continue the discussion there

* chore: drop support for Windows 7 & 8 * chore: remove disable-redraw-lock.patch * chore: update patches * Update docs/breaking-changes.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * Update docs/breaking-changes.md Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> * fix breaking-changes.md * chore: note last supported version Co-authored-by: Jeremy Rose <jeremya@chromium.org> * chore: add link to deprecation policy * Update docs/breaking-changes.md Co-authored-by: Jeremy Rose <jeremya@chromium.org> * update README.md Co-authored-by: Milan Burda <miburda@microsoft.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Erick Zhao <erick@hotmail.ca> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 22, 2022

miniak changed the title ~~chore: statically link Windows APIs available on Windows 10+~~ chore: drop support for Windows 7 & 8 Nov 22, 2022

miniak force-pushed the miniak/drop-win-7-8-support branch 2 times, most recently from c0043a7 to 67736f8 Compare November 22, 2022 20:44

miniak requested a review from a team as a code owner November 22, 2022 20:44

miniak force-pushed the miniak/drop-win-7-8-support branch 3 times, most recently from b1eb6d0 to 5fa490e Compare November 22, 2022 20:52

nornagon requested changes Nov 22, 2022

View reviewed changes

nornagon added the semver/major incompatible API changes label Nov 22, 2022

electron-cation bot added the api-review/requested 🗳 label Nov 22, 2022

nornagon added the no-backport label Nov 22, 2022

erickzhao removed the api-review/requested 🗳 label Nov 22, 2022

electron-cation bot added the api-review/requested 🗳 label Nov 22, 2022

miniak force-pushed the miniak/drop-win-7-8-support branch from 5fa490e to 737d8d1 Compare November 22, 2022 20:55

Milan Burda added 2 commits November 22, 2022 22:03

chore: drop support for Windows 7 & 8

6b0d303

chore: remove disable-redraw-lock.patch

9f02be1

miniak force-pushed the miniak/drop-win-7-8-support branch from 737d8d1 to 9f02be1 Compare November 22, 2022 21:03

chore: update patches

24f0a44

erickzhao reviewed Nov 22, 2022

View reviewed changes

docs/breaking-changes.md Outdated Show resolved Hide resolved

miniak and others added 2 commits November 23, 2022 01:01

Update docs/breaking-changes.md

4bc438b

Co-authored-by: Erick Zhao <erick@hotmail.ca>

Merge branch 'main' into miniak/drop-win-7-8-support

8516c66

VerteDinde approved these changes Nov 28, 2022

View reviewed changes

docs/breaking-changes.md Outdated Show resolved Hide resolved

Update docs/breaking-changes.md

d01e033

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

miniak requested a review from nornagon November 28, 2022 17:32

fix breaking-changes.md

0929e75

nornagon approved these changes Nov 28, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

chore: note last supported version

371f640

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

nornagon requested changes Nov 28, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

nornagon approved these changes Nov 29, 2022

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 29, 2022

miniak changed the title ~~chore: drop support for Windows 7 & 8~~ chore: drop support for Windows 7 / 8 / 8.1 Nov 30, 2022

nornagon reviewed Nov 30, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

nornagon reviewed Nov 30, 2022

View reviewed changes

docs/breaking-changes.md Outdated Show resolved Hide resolved

miniak and others added 2 commits November 30, 2022 22:26

Update docs/breaking-changes.md

676a871

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

update README.md

634c48a

nornagon approved these changes Dec 1, 2022

View reviewed changes

VerteDinde added target/23-x-y PR should also be added to the "23-x-y" branch. and removed no-backport labels Dec 1, 2022

VerteDinde merged commit eb29148 into main Dec 1, 2022

VerteDinde deleted the miniak/drop-win-7-8-support branch December 1, 2022 01:13

trop bot mentioned this pull request Dec 1, 2022

chore: drop support for Windows 7 / 8 / 8.1 #36513

Merged

trop bot added in-flight/23-x-y merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. in-flight/23-x-y labels Dec 1, 2022

miniak mentioned this pull request Jan 24, 2023

chore: update README.md #37002

Merged

commit-lint bot mentioned this pull request Mar 15, 2023

[pull] main from electron:main Blaquez-home/electron#3

Open

y489436672 mentioned this pull request May 10, 2023

[Bug]: Application failed to start in Win7 #37945

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: drop support for Windows 7 / 8 / 8.1 #36427

chore: drop support for Windows 7 / 8 / 8.1 #36427

miniak commented Nov 22, 2022 •

edited

nornagon left a comment

miniak commented Nov 22, 2022 •

edited

VerteDinde left a comment

nornagon left a comment

nornagon left a comment

miniak commented Nov 30, 2022 •

edited

release-clerk bot commented Dec 1, 2022

trop bot commented Dec 1, 2022

GitMensch commented Dec 1, 2022

pushkin- commented Dec 15, 2022 •

edited

CommonLoon102 commented Jan 11, 2023

miniak commented Jan 23, 2023 •

edited

miniak commented Jan 23, 2023 •

edited

miniak commented Jan 23, 2023

chore: drop support for Windows 7 / 8 / 8.1 #36427

chore: drop support for Windows 7 / 8 / 8.1 #36427

Conversation

miniak commented Nov 22, 2022 • edited

Description of Change

Checklist

Release Notes

nornagon left a comment

Choose a reason for hiding this comment

miniak commented Nov 22, 2022 • edited

VerteDinde left a comment

Choose a reason for hiding this comment

nornagon left a comment

Choose a reason for hiding this comment

nornagon left a comment

Choose a reason for hiding this comment

miniak commented Nov 30, 2022 • edited

release-clerk bot commented Dec 1, 2022

trop bot commented Dec 1, 2022

GitMensch commented Dec 1, 2022

pushkin- commented Dec 15, 2022 • edited

CommonLoon102 commented Jan 11, 2023

miniak commented Jan 23, 2023 • edited

miniak commented Jan 23, 2023 • edited

miniak commented Jan 23, 2023

miniak commented Nov 22, 2022 •

edited

miniak commented Nov 22, 2022 •

edited

miniak commented Nov 30, 2022 •

edited

pushkin- commented Dec 15, 2022 •

edited

miniak commented Jan 23, 2023 •

edited

miniak commented Jan 23, 2023 •

edited