fix: crash when BrowserView with destroyed webcontents is reused

[CezaryKulakowski]

Fixed #36371.

Description of Change

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: fixed crash when BrowserView with destroyed webcontents is reused

[codebytere]

Please add a regression test to this!

Additionally - this does prevent a full crash but what also seems to be happening is that the BrowserView webContents is being destroyed when maybe it shouldn't be. This is happening as a result of #35509 - specifically this change cc @nornagon

We should consider whether that's the destruction order we want and fix it there as opposed to catching the destroyed webContents as is being done in this change.

[CezaryKulakowski]

I've pushed fixup with test. It crashes without this fix.

[nornagon]

Thanks for the new test, pulled the test into #35658, which threw a JS exception in this case, which is now fixed.

This PR will be obsoleted if #35658 lands.

[codebytere]

Handled in #37420 - apologies for not getting to this sooner before i realized it.