Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: force ninja binary to the right arch after src cache restore #36401

Merged
merged 1 commit into from Nov 19, 2022
Merged

build: force ninja binary to the right arch after src cache restore #36401

merged 1 commit into from Nov 19, 2022

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Nov 19, 2022 •
edited

As in title, this was caused by https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4034942 (Credit @VerteDinde for tracking down that change)

Notes: none

@MarshallOfSound MarshallOfSound added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/none target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Nov 19, 2022
@MarshallOfSound MarshallOfSound merged commit 3a94634 into main Nov 19, 2022
@MarshallOfSound MarshallOfSound deleted the fix-ninja-binary branch November 19, 2022 07:45
@release-clerk
Copy link

release-clerk bot commented Nov 19, 2022

No Release Notes

@trop trop bot mentioned this pull request Nov 19, 2022
Closed
@trop
Copy link
Contributor

trop bot commented Nov 19, 2022

I have automatically backported this PR to "19-x-y", please check out #36402

This was referenced Nov 19, 2022
Closed
Merged
@trop trop bot mentioned this pull request Nov 19, 2022
Closed
@trop trop bot removed the target/19-x-y label Nov 19, 2022
@trop
Copy link
Contributor

trop bot commented Nov 19, 2022

I have automatically backported this PR to "21-x-y", please check out #36403

@trop
Copy link
Contributor

trop bot commented Nov 19, 2022

I have automatically backported this PR to "22-x-y", please check out #36404

@trop
Copy link
Contributor

trop bot commented Nov 19, 2022

I have automatically backported this PR to "20-x-y", please check out #36405

@trop trop bot added in-flight/21-x-y merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. target/20-x-y labels Nov 19, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@MarshallOfSound @khalwa
build: force ninja binary to the right arch after src cache restore (e…
054c0db 
…lectron#36401)
@commit-lint commit-lint bot mentioned this pull request Mar 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/22-x-y PR was merged to the "22-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @VerteDinde