Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix dangling promise in npm install #36398

Merged
merged 3 commits into from Nov 22, 2022
Merged

chore: fix dangling promise in npm install #36398

merged 3 commits into from Nov 22, 2022

Commits on Nov 18, 2022

  1. Fix dangling promise introduced in #33979 

    Co-authored-by: hyrious <hyrious@outlook.com>
    @trop @hyrious
    trop[bot] and hyrious committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    776bf56 View commit details
    Browse the repository at this point in the history

  2. fix reject in callback 

    Co-authored-by: hyrious <hyrious@outlook.com>
    @trop @hyrious
    trop[bot] and hyrious committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    424a1d1 View commit details
    Browse the repository at this point in the history

  3. simplify code 

    Co-authored-by: Black-Hole <158blackhole@gmail.com>

Co-authored-by: hyrious <hyrious@outlook.com>
    @trop @hyrious
    trop[bot] and hyrious committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2efdc85 View commit details
    Browse the repository at this point in the history