chore: fix dangling promise in npm install #36379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
hyrious
changed the title
BlackHole1
suggested changes
Nov 17, 2022
Co-authored-by: Black-Hole <158blackhole@gmail.com>
MarshallOfSound
approved these changes
Nov 17, 2022
MarshallOfSound
added
semver/patch
codebytere
approved these changes
Nov 17, 2022
codebytere
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
No Release Notes |
|
I have automatically backported this PR to "22-x-y", please check out #36398 |
trop
bot
removed
the
target/22-x-y
|
I have automatically backported this PR to "21-x-y", please check out #36399 |
|
I have automatically backported this PR to "20-x-y", please check out #36400 |
trop
bot
added
merged/20-x-y
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* Fix dangling promise introduced in electron#33979 * fix reject in callback * simplify code Co-authored-by: Black-Hole <158blackhole@gmail.com> Co-authored-by: Black-Hole <158blackhole@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix an unresolved promise introduced in #33979, where the
resolveis never called.This problem was not observable because there's no variable holding reference to the promise, so V8 will correctly GC it. But the code logic still has problem.
Checklist
npm testpassesRelease Notes
Notes: no-notes