Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args #36378

Merged
merged 1 commit into from Nov 17, 2022
Merged

fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args #36378

merged 1 commit into from Nov 17, 2022

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Nov 16, 2022 •
edited

Description of Change

Recent V8 changes added a new --turbo-profiling-input flag to mksnapshot_args but the default profile is empty, so we do not need to include this argument. For additional context, see https://source.chromium.org/chromium/chromium/src/+/main:v8/BUILD.gn;l=179

Checklist

Release Notes

Notes: Removed unneeded --turbo-profiling-input argument from mksnapshot_args.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 16, 2022
@jkleinsc jkleinsc added semver/patch backwards-compatible bug fixes target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Nov 16, 2022
@jkleinsc jkleinsc changed the title fix: remove unneeded --turbo-profiling-input args from mksnapshot_args fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args Nov 16, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 17, 2022
@jkleinsc jkleinsc merged commit 7529ebf into main Nov 17, 2022
@jkleinsc jkleinsc deleted the fixup-mksnapshot-args branch November 17, 2022 22:49
@release-clerk
Copy link

release-clerk bot commented Nov 17, 2022

Release Notes Persisted

Removed unneeded --turbo-profiling-input argument from mksnapshot_args.

@trop
Copy link
Contributor

trop bot commented Nov 17, 2022

I was unable to backport this PR to "21-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/21-x-y PR should also be added to the "21-x-y" branch. label Nov 17, 2022
@trop
Copy link
Contributor

trop bot commented Nov 17, 2022

I was unable to backport this PR to "22-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/21-x-y needs-manual-bp/22-x-y and removed target/22-x-y PR should also be added to the "22-x-y" branch. labels Nov 17, 2022
VerteDinde added a commit that referenced this pull request Nov 18, 2022
@VerteDinde
Revert "fix: remove unneeded --turbo-profiling-input arg from mksnaps…
5d3baf2 
…hot_args (#36378)"

This reverts commit 7529ebf.
@craftzdog craftzdog mentioned this pull request Nov 24, 2022
Closed
jkleinsc added a commit that referenced this pull request Nov 28, 2022
@jkleinsc
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args (…
470a44f 
…#36378)

fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
(cherry picked from commit 7529ebf)
@jkleinsc jkleinsc mentioned this pull request Nov 28, 2022
Merged
@trop
Copy link
Contributor

trop bot commented Nov 28, 2022

@jkleinsc has manually backported this PR to "22-x-y", please check out #36463

georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Nov 28, 2022
@jkleinsc @georgexu99
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args (…
17980d9 
…electron#36378)

fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
@georgexu99 georgexu99 mentioned this pull request Nov 28, 2022
Closed
5 tasks
@trop
Copy link
Contributor

trop bot commented Nov 28, 2022

@georgexu99 has manually backported this PR to "22-x-y", please check out #36467

@georgexu99
Copy link
Contributor

oops, I was too slow and didn't reload github :P

@trop trop bot removed the in-flight/22-x-y label Nov 28, 2022
@trop trop bot added the merged/22-x-y PR was merged to the "22-x-y" branch. label Nov 28, 2022
VerteDinde pushed a commit that referenced this pull request Nov 28, 2022
@jkleinsc
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args… (
ccc5a7a 
#36463)

fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args (#36378)

fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
(cherry picked from commit 7529ebf)
@trop trop bot mentioned this pull request Nov 30, 2022
Merged
trop bot added a commit that referenced this pull request Nov 30, 2022
@trop @jkleinsc
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args (…
98bbc2f 
…#36378)

fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
(cherry picked from commit 7529ebf)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot added the merged/21-x-y PR was merged to the "21-x-y" branch. label Nov 30, 2022
jkleinsc added a commit that referenced this pull request Nov 30, 2022
@trop @jkleinsc
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args… (
ba93dc3 
#36495)

fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args (#36378)

fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
(cherry picked from commit 7529ebf)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
@trop trop bot removed the in-flight/21-x-y label Nov 30, 2022
@jkleinsc jkleinsc mentioned this pull request Dec 1, 2022
Merged
2 tasks
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@jkleinsc @khalwa
fix: remove unneeded --turbo-profiling-input arg from mksnapshot_args (…
46f5b08 
…electron#36378)

fix: remove unneeded --turbo-profiling-input args from mksnapshot_args
@commit-lint commit-lint bot mentioned this pull request Mar 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: mksnapshot args shipped with v21 doen't work properly
4 participants
@jkleinsc @georgexu99 @codebytere @VerteDinde