Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abort ShipIt installation attempt at the final mile if the app is running #36362

Merged
merged 1 commit into from Nov 16, 2022

Conversation

MarshallOfSound
Copy link
Member

Backport of #36130.

See that PR for details.

Notes: Fixed race condition during update on macOS that could result in TCC and Keychain errors

…s running (#36130)

* fix: abort ShipIt installation attempt at the final mile if the app is running

* chore: remove only

* Update patches/squirrel.mac/fix_abort_installation_attempt_at_the_final_mile_if_the_app_is.patch

Co-authored-by: Jeremy Rose <jeremya@chromium.org>

* chore: update patches

* spec: make the ShipIt process lister helper more resilient

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@MarshallOfSound MarshallOfSound requested a review from a team as a code owner November 15, 2022 20:17
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2022
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 15, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 15, 2022
@MarshallOfSound
Copy link
Member Author

Not sure yet as to whether this should be backported, doing some more extensive testing on nightlies first

@codebytere codebytere merged commit 5d418c5 into 22-x-y Nov 16, 2022
@codebytere codebytere deleted the manual-bp/MarshallOfSound/pr/36130/branch/22-x-y branch November 16, 2022 09:48
@release-clerk
Copy link

release-clerk bot commented Nov 16, 2022

Release Notes Persisted

Fixed race condition during update on macOS that could result in TCC and Keychain errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants