Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove out cache #36360

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 0 additions & 43 deletions .circleci/config/base.yml
Expand Up @@ -906,14 +906,6 @@ step-maybe-restore-git-cache: &step-maybe-restore-git-cache
- v1-git-cache-{{ checksum "src/electron/.circle-sync-done" }}
name: Conditionally restoring git cache

step-restore-out-cache: &step-restore-out-cache
restore_cache:
paths:
- ./src/out/Default
keys:
- v10-out-cache-{{ checksum "src/electron/.depshash" }}-{{ checksum "src/electron/.depshash-target" }}
name: Restoring out cache

step-set-git-cache-path: &step-set-git-cache-path
run:
name: Set GIT_CACHE_PATH to make gclient to use the cache
Expand All @@ -931,13 +923,6 @@ step-save-git-cache: &step-save-git-cache
key: v1-git-cache-{{ checksum "src/electron/.circle-sync-done" }}-{{ checksum "src/electron/DEPS" }}
name: Persisting git cache

step-save-out-cache: &step-save-out-cache
save_cache:
paths:
- ./src/out/Default
key: v10-out-cache-{{ checksum "src/electron/.depshash" }}-{{ checksum "src/electron/.depshash-target" }}
name: Persisting out cache

step-run-electron-only-hooks: &step-run-electron-only-hooks
run:
name: Run Electron Only Hooks
Expand Down Expand Up @@ -1355,9 +1340,6 @@ commands:
build:
type: boolean
default: true
use-out-cache:
type: boolean
default: true
restore-src-cache:
type: boolean
default: true
Expand Down Expand Up @@ -1480,10 +1462,6 @@ commands:
- *step-delete-git-directories

# Electron app
- when:
condition: << parameters.use-out-cache >>
steps:
- *step-restore-out-cache
- *step-gn-gen-default
- *step-electron-build
- *step-maybe-electron-dist-strip
Expand Down Expand Up @@ -1526,22 +1504,6 @@ commands:
condition: << parameters.build >>
steps:
- move_and_store_all_artifacts
- run:
name: Remove the big things on macOS, this seems to be better on average
command: |
if [ "`uname`" == "Darwin" ]; then
mkdir -p src/out/Default
cd src/out/Default
find . -type f -size +50M -delete
mkdir -p gen/electron
cd gen/electron
# These files do not seem to like being in a cache, let us remove them
find . -type f -name '*_pkg_info' -delete
fi
- when:
condition: << parameters.use-out-cache >>
steps:
- *step-save-out-cache

- *step-maybe-notify-slack-failure

Expand Down Expand Up @@ -1695,7 +1657,6 @@ jobs:
persist: true
checkout: false
checkout-and-assume-cache: true
use-out-cache: false

linux-x64-testing-asan:
executor:
Expand All @@ -1712,7 +1673,6 @@ jobs:
- electron-build:
persist: true
checkout: true
use-out-cache: false
build-nonproprietary-ffmpeg: false

linux-x64-testing-no-run-as-node:
Expand All @@ -1729,7 +1689,6 @@ jobs:
- electron-build:
persist: false
checkout: true
use-out-cache: false

linux-x64-testing-gn-check:
executor:
Expand Down Expand Up @@ -1780,7 +1739,6 @@ jobs:
persist: true
checkout: false
checkout-and-assume-cache: true
use-out-cache: false

linux-arm-publish:
executor:
Expand Down Expand Up @@ -1823,7 +1781,6 @@ jobs:
persist: true
checkout: false
checkout-and-assume-cache: true
use-out-cache: false

linux-arm64-testing-gn-check:
executor:
Expand Down