feat: add support for WebUSB #36289
Merged
feat: add support for WebUSB #36289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
ckerr
reviewed
Nov 10, 2022
jkleinsc
added
semver/minor
electron-cation
bot
added
new-pr 🌱
Co-authored-by: Charles Kerr <charles@charleskerr.com>
jkleinsc
force-pushed
the
implement-web-usb
branch
from
5e766b0
to
f4c37e5
Compare
…vationTraits<> in chrome/browser/ https://chromium-review.googlesource.com/c/chromium/src/+/4016595
|
Release Notes Persisted
|
|
API LGTM |
|
The device list is always empty. See #36615. |
3 tasks
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* feat: add support for WebUSB * fixup for gn check * fixup gn check on Windows * Apply review feedback Co-authored-by: Charles Kerr <charles@charleskerr.com> * chore: address review feedback * chore: removed unneeded code * Migrate non-default ScopedObservation<> instantiations to ScopedObservationTraits<> in chrome/browser/ https://chromium-review.googlesource.com/c/chromium/src/+/4016595 Co-authored-by: Charles Kerr <charles@charleskerr.com>
3 tasks
4 tasks
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables use of the WebUSB API in Electron by exposing several new events on Session:
select-usb-device- fired whennavigator.usb.requestDeviceis called so that an Electron developer can programmatically select a USB device.usb-device-added- emitted afternavigator.usb.requestDevicehas been called andselect-usb-devicehas fired if a new device becomes available before the callback fromselect-usb-deviceis called. This event is intended for use when using a UI to ask users to pick a device so that the UI can be updated with the newly added device.usb-device-removed- emitted afternavigator.usb.requestDevicehas been called andselect-usb-devicehas fired if a device has been removed before the callback fromselect-usb-deviceis called. This event is intended for use when using a UI to ask users to pick a device so that the UI can be updated to remove the specified device.usb-device-revoked- emitted afterUSBDevice.forget()has been called. This event can be used to help maintain persistent storage of permissions whensetDevicePermissionHandleris used.Additionally,
setDevicePermissionHandler(handler)on Session has been updated to allow developers to provide default permissioning to devices without callingnavigator.usb.requestDevicefirst.Checklist
npm testpassesRelease Notes
Notes: Added support for WebUSB