build: fix building with enable_plugins = false

[miniak]

Description of Change

electron_renderer_pepper_host_factory.h is referenced by pepper_helper.cc and needs to share the same buildflag.

electron/shell/renderer/pepper_helper.cc

Line 12 in 169cf53

#include "electron/shell/renderer/electron_renderer_pepper_host_factory.h"

electron/shell/renderer/pepper_helper.cc

Lines 25 to 26 in 169cf53

	host->GetPpapiHost()->AddHostFactoryFilter(
	std::make_unique<ElectronRendererPepperHostFactory>(host));

Without the fix the build fails with:

lld-link: error: undefined symbol: public: __cdecl ppapi::host::ResourceHost::ResourceHost(class ppapi::host::PpapiHost *, int, int)

>>> referenced by .\..\..\electron\shell\renderer\electron_renderer_pepper_host_factory.cc:103
>>>               obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(public: virtual class std::Cr::unique_ptr<class ppapi::host::ResourceHost, struct std::Cr::default_delete<class ppapi::host::ResourceHost>> __cdecl ElectronRendererPepperHostFactory::CreateResourceHost(class ppapi::host::PpapiHost *, int, int, class IPC::Message const &))

lld-link: error: undefined symbol: public: virtual __cdecl ppapi::host::ResourceHost::~ResourceHost(void)
>>> referenced by .\..\..\electron\shell\renderer\electron_renderer_pepper_host_factory.cc:28
>>>               obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(public: virtual void * __cdecl PepperUMAHost::`scalar deleting dtor'(unsigned int))

lld-link: error: undefined symbol: public: static bool __cdecl IPC::MessageT<struct PpapiHostMsg_UMA_HistogramCustomCounts_Meta, class std::Cr::tuple<class std::Cr::basic_string<char, struct std::Cr::char_traits<char>, class std::Cr::allocator<char>>, int, int, int, unsigned int>, void>::Read(class IPC::Message const *, class std::Cr::tuple<class std::Cr::basic_string<char, struct std::Cr::char_traits<char>, class std::Cr::allocator<char>>, int, int, int, unsigned int> *)
>>> referenced by .\..\..\electron\shell\renderer\electron_renderer_pepper_host_factory.cc:37
>>>               obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(public: virtual int __cdecl PepperUMAHost::OnResourceMessageReceived(class IPC::Message const &, struct ppapi::host::HostMessageContext *))

lld-link: error: undefined symbol: public: static bool __cdecl IPC::MessageT<struct PpapiHostMsg_UMA_HistogramCustomTimes_Meta, class std::Cr::tuple<class std::Cr::basic_string<char, struct std::Cr::char_traits<char>, class std::Cr::allocator<char>>, __int64, __int64, __int64, unsigned int>, void>::Read(class IPC::Message const *, class std::Cr::tuple<class std::Cr::basic_string<char, struct std::Cr::char_traits<char>, class std::Cr::allocator<char>>, __int64, __int64, __int64, unsigned int> *)
>>> referenced by .\..\..\electron\shell\renderer\electron_renderer_pepper_host_factory.cc:35
>>>               obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(public: virtual int __cdecl PepperUMAHost::OnResourceMessageReceived(class IPC::Message const &, struct ppapi::host::HostMessageContext *))

lld-link: error: undefined symbol: public: static bool __cdecl IPC::MessageT<struct PpapiHostMsg_UMA_HistogramEnumeration_Meta, class std::Cr::tuple<class std::Cr::basic_string<char, struct std::Cr::char_traits<char>, class std::Cr::allocator<char>>, int, int>, void>::Read(class IPC::Message const *, class std::Cr::tuple<class std::Cr::basic_string<char, struct std::Cr::char_traits<char>, class std::Cr::allocator<char>>, int, int> *)
>>> referenced by .\..\..\electron\shell\renderer\electron_renderer_pepper_host_factory.cc:39
>>>               obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(public: virtual int __cdecl PepperUMAHost::OnResourceMessageReceived(class IPC::Message const &, struct ppapi::host::HostMessageContext *))

lld-link: error: undefined symbol: public: virtual bool __cdecl ppapi::host::ResourceHost::HandleMessage(class IPC::Message const &, struct ppapi::host::HostMessageContext *)
>>> referenced by obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(const PepperUMAHost::`vftable')

lld-link: error: undefined symbol: public: virtual void __cdecl ppapi::host::ResourceHost::SendReply(struct ppapi::host::ReplyMessageContext const &, class IPC::Message const &)
>>> referenced by obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(const PepperUMAHost::`vftable')

lld-link: error: undefined symbol: public: virtual bool __cdecl ppapi::host::ResourceHost::IsFileRefHost(void)
>>> referenced by obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(const PepperUMAHost::`vftable')

lld-link: error: undefined symbol: public: virtual bool __cdecl ppapi::host::ResourceHost::IsFileSystemHost(void)
>>> referenced by obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(const PepperUMAHost::`vftable')

lld-link: error: undefined symbol: public: virtual bool __cdecl ppapi::host::ResourceHost::IsGraphics2DHost(void)
>>> referenced by obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(const PepperUMAHost::`vftable')

lld-link: error: undefined symbol: public: virtual bool __cdecl ppapi::host::ResourceHost::IsMediaStreamVideoTrackHost(void)
>>> referenced by obj/electron/electron_lib/electron_renderer_pepper_host_factory.obj:(const PepperUMAHost::`vftable')

ninja: build stopped: cannot make progress due to previous errors.

Checklist

• PR description included and stakeholders cc'd
• npm test passes

Release Notes

Notes: none

[brjsp]

I think this is the same issue issue i noticed in #36190.

What is the difference between enable_ppapi and enable_plugins, btw? (We have disabled both of these in openSUSE because none of the apps we ship depend on either Pepper or PDF support)

[release-clerk]

No Release Notes

[trop]

I was unable to backport this PR to "21-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "22-x-y", please check out #36201

[miniak]

@brjsp there are now separate enable_ppapi and enable_plugins flags. It will require another follow-up PR to support them properly.

[trop]

@miniak has manually backported this PR to "21-x-y", please check out #36202

[miniak]

/trop run backport-to 20-x-y

[trop]

The backport process for this PR has been manually initiated - sending your PR to 20-x-y!

[trop]

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

[trop]

@miniak has manually backported this PR to "20-x-y", please check out #36494