build: prefix version in uploader script #36169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Oct 27, 2022
nornagon
reviewed
Oct 27, 2022
VerteDinde
added
target/19-x-y
target/21-x-y
|
No Release Notes |
|
I have automatically backported this PR to "21-x-y", please check out #36173 |
trop
bot
added
in-flight/21-x-y
and removed
target/21-x-y
This was referenced Oct 27, 2022
|
I have automatically backported this PR to "22-x-y", please check out #36174 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "19-x-y", please check out #36175 |
|
I have automatically backported this PR to "20-x-y", please check out #36176 |
trop
bot
added
merged/22-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
build: prefix v in uploader script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In a previous PR, we removed the "v" prefix from Electron version, as there were several areas in the code that weren't expecting it. However, the upload script still expects a prefix. This PR re-adds the prefix to the upload script.
Checklist
npm testpassesRelease Notes
Notes: none