Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: determine electron version from tags not files #36135

Merged
merged 6 commits into from Oct 28, 2022
Merged

build: determine electron version from tags not files #36135

merged 6 commits into from Oct 28, 2022

Commits on Oct 26, 2022

  1. build: determine electron version from tags not files (#36106) 

    * build: determine electron version from tags not files

* build: make electron_version dependent on packed-refs and git HEAD

* build: do not delete electron/.git

* build: do not revert a commit we didn't make

* build: gen version file instead of just writing it

* build: update cache and ninja targets

* build: copy resource.h to generated electron.rc

* build: electron_win32_resources should be public deps

* build: also copy the icon

Co-authored-by: MarshallOfSound <marshallofsound@electronjs.org>
    @VerteDinde @MarshallOfSound
    VerteDinde and MarshallOfSound committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d1fdcdb View commit details
    Browse the repository at this point in the history

  2. chore: fixup patches

    @VerteDinde
    VerteDinde committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f7c744f View commit details
    Browse the repository at this point in the history

  3. chore: update patches

    @patchup
    patchup[bot] committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2098d36 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. build: ensure get-version runs in the electron git checkout (#36128)

    @MarshallOfSound @VerteDinde
    MarshallOfSound authored and VerteDinde committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c5033f1 View commit details
    Browse the repository at this point in the history

  2. build: strip v in the getElectronVersion helper

    @MarshallOfSound @VerteDinde
    MarshallOfSound authored and VerteDinde committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    873c777 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. build: use npm@7 for npm view command

    @MarshallOfSound @VerteDinde
    MarshallOfSound authored and VerteDinde committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    17bf4a5 View commit details
    Browse the repository at this point in the history