Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve loadURL properly for in-page navigations #36129

Merged
merged 1 commit into from Oct 26, 2022
Merged

fix: resolve loadURL properly for in-page navigations #36129

merged 1 commit into from Oct 26, 2022

Conversation

nornagon
Copy link
Member

Description of Change

Fixes #28208.

Checklist

Release Notes

Notes: Fixed spurious promise rejection in webContents.loadURL when navigating to a hash.

@nornagon nornagon added semver/patch backwards-compatible bug fixes target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 25, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 25, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 26, 2022
@nornagon
Copy link
Member Author

failures are flakes; merging.

@nornagon nornagon merged commit 625b461 into main Oct 26, 2022
@nornagon nornagon deleted the loadurl-hash-nav branch October 26, 2022 20:57
@release-clerk
Copy link

release-clerk bot commented Oct 26, 2022

Release Notes Persisted

Fixed spurious promise rejection in webContents.loadURL when navigating to a hash.

This was referenced Oct 26, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 26, 2022

I have automatically backported this PR to "20-x-y", please check out #36149

@trop
Copy link
Contributor

trop bot commented Oct 26, 2022

I have automatically backported this PR to "21-x-y", please check out #36150

@trop
Copy link
Contributor

trop bot commented Oct 26, 2022

I have automatically backported this PR to "22-x-y", please check out #36151

@trop trop bot added in-flight/21-x-y merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/21-x-y labels Oct 26, 2022
@Quorafind Quorafind mentioned this pull request Nov 22, 2022
Merged
@MounicaChanda0809 MounicaChanda0809 mentioned this pull request Dec 20, 2022
Closed
3 tasks
@commit-lint commit-lint bot mentioned this pull request Feb 16, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@nornagon @khalwa
fix: resolve loadURL properly for in-page navigations (electron#36129)
9582572
@mix3d mix3d mentioned this pull request Mar 13, 2023
Closed
3 tasks
@TomaszMa TomaszMa mentioned this pull request Jul 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserWindow#loadURL() throw an error when I load same page with different location hash
4 participants
@nornagon @zcbenz @deepak1556 @codebytere