Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UtilityProcess API #36089

Merged

Commits on Nov 15, 2022

  1. feat: UtilityProcess API (#34980)

    * chore: initial scaffolding
    
    * chore: implement interface and docs
    
    * chore: address code style review
    
    * fix: cleanup of utility process on shutdown
    
    * chore: simplify NodeBindings::CreateEnvironment
    
    * chore: rename disableLibraryValidation => allowLoadingUnsignedLibraries
    
    * chore: implement process.parentPort
    
    * chore(posix): implement stdio pipe interface
    
    * chore(win): implement stdio interface
    
    * chore: reenable SetNodeOptions for utility process
    
    * chore: add specs
    
    * chore: fix lint
    
    * fix: update kill API
    
    * fix: update process.parentPort API
    
    * fix: exit event
    
    * docs: update exit event
    
    * fix: tests on linux
    
    * chore: expand on some comments
    
    * fix: shutdown of pipe reader
    
    Avoid logging since it is always the case that reader end of
    pipe will terminate after the child process.
    
    * fix: remove exit code check for crash spec
    
    * fix: rm PR_SET_NO_NEW_PRIVS for unsandbox utility process
    
    * chore: fix incorrect rebase
    
    * fix: address review feedback
    
    * chore: rename utility_process -> utility
    
    * chore: update docs
    
    * chore: cleanup c++ implemantation
    
    * fix: leak in NodeServiceHost impl
    
    * chore: minor cleanup
    
    * chore: cleanup JS implementation
    
    * chore: flip default stdio to inherit
    
    * fix: some api improvements
    
    * Support cwd option
    * Remove path restriction for modulePath
    * Rewire impl for env support
    
    * fix: add tests for cwd and env option
    
    * chore: alt impl for reading stdio handles
    
    * chore: support message queuing
    
    * chore: fix lint
    
    * chore: new UtilityProcess => utilityProcess.fork
    
    * fix: support for uncaught exception exits
    
    * chore: remove process.execArgv as default
    
    * fix: windows build
    
    * fix: style changes
    
    * fix: docs and style changes
    
    * chore: update patches
    
    * spec: disable flaky test on win32 arm CI
    
    Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
    
    Co-authored-by: Robo <hop2deep@gmail.com>
    trop[bot] and deepak1556 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1e60927 View commit details
    Browse the repository at this point in the history
  2. chore: update patches

    deepak1556 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    fff908c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba01054 View commit details
    Browse the repository at this point in the history