fix: printToPDF default margins #36060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The document printToPDF has a 1cm margin and this default value has been added in the code.
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
codebytere
approved these changes
Oct 18, 2022
codebytere
added
semver/patch
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "20-x-y" cleanly; |
trop bot
added a commit
that referenced
this pull request
Oct 19, 2022
printToPDF default margins The document printToPDF has a 1cm margin and this default value has been added in the code. Co-authored-by: Yusoo <Yusoo@users.noreply.github.com>
trop bot
added a commit
that referenced
this pull request
Oct 19, 2022
printToPDF default margins The document printToPDF has a 1cm margin and this default value has been added in the code. Co-authored-by: Yusoo <Yusoo@users.noreply.github.com>
|
I have automatically backported this PR to "21-x-y", please check out #36072 |
trop
bot
added
in-flight/21-x-y
and removed
target/21-x-y
|
I have automatically backported this PR to "22-x-y", please check out #36073 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Oct 20, 2022
fix: printToPDF default margins (#36060) printToPDF default margins The document printToPDF has a 1cm margin and this default value has been added in the code. Co-authored-by: Yusoo <Yusoo@users.noreply.github.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Yusoo <Yusoo@users.noreply.github.com>
trop
bot
added
merged/21-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Oct 20, 2022
fix: printToPDF default margins (#36060) printToPDF default margins The document printToPDF has a 1cm margin and this default value has been added in the code. Co-authored-by: Yusoo <Yusoo@users.noreply.github.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Yusoo <Yusoo@users.noreply.github.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
printToPDF default margins The document printToPDF has a 1cm margin and this default value has been added in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the document
webContents.printToPDFhas a default value of 1cm for the margins, however it does not.Release Notes
Notes: default margin has been added in the code.