Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: headless job tracking in printToPDF #36046

Merged
merged 1 commit into from Oct 18, 2022
Merged

fix: headless job tracking in printToPDF #36046

merged 1 commit into from Oct 18, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Fixes headless job tracking for contents.printToPDF(), which was incorrectly/unintentionally removed in a recent Chromium roll.

Checklist

Release Notes

Notes: Fixed a potential issue when calling webContents.printToPDF().

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 17, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 17, 2022
@codebytere codebytere force-pushed the fix-headless-values branch 2 times, most recently from 108d685 to 28495db Compare October 17, 2022 08:13
@deepak1556
Copy link
Member

Does #36051 supersede this PR ?

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2022
@codebytere
Copy link
Member Author

@deepak1556 similar but i'd prefer to merge this separately since they're addressing separate functional areas i'd say!

deepak1556
deepak1556 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on base::Erase

@codebytere codebytere merged commit a8d89b3 into main Oct 18, 2022
@codebytere codebytere deleted the fix-headless-values branch October 18, 2022 13:46
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2022

Release Notes Persisted

Fixed a potential issue when calling webContents.printToPDF().

This was referenced Oct 18, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 18, 2022

I have automatically backported this PR to "21-x-y", please check out #36064

@trop trop bot added in-flight/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Oct 18, 2022
@trop
Copy link
Contributor

trop bot commented Oct 18, 2022

I have automatically backported this PR to "22-x-y", please check out #36065

@trop trop bot added in-flight/22-x-y merged/22-x-y PR was merged to the "22-x-y" branch. merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/22-x-y labels Oct 18, 2022
@trop trop bot removed the in-flight/21-x-y label Oct 20, 2022
@commit-lint commit-lint bot mentioned this pull request Feb 13, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: headless job tracking in printToPDF (electron#36046)
b747126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @deepak1556 @zcbenz