Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: override app's desktop name and v8 flags in default-app #35997

Merged
merged 1 commit into from Oct 17, 2022
Merged

fix: override app's desktop name and v8 flags in default-app #35997

merged 1 commit into from Oct 17, 2022

Conversation

Piroro-hs
Copy link
Contributor

Description of Change

Fixes #35967 (and maybe #34801).
Override app's desktop name and v8 flags when launching local app from default-app.

Checklist

Release Notes

Notes: Fixed v8 flags and desktop name in package.json does not hornored when running local app using electron cli.

@welcome
Copy link

welcome bot commented Oct 12, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 12, 2022
@zcbenz zcbenz added the semver/patch backwards-compatible bug fixes label Oct 17, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 17, 2022
@zcbenz zcbenz added target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. labels Oct 17, 2022
MarshallOfSound
MarshallOfSound approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is purely aligning default_app with browser/init I'm ok with this. I have other thoughts on packageJson.v8Flags but they can be thought about elsewhere.

@codebytere codebytere merged commit 295c533 into electron:main Oct 17, 2022
@welcome
Copy link

welcome bot commented Oct 17, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Oct 17, 2022

Release Notes Persisted

Fixed v8 flags and desktop name in package.json does not hornored when running local app using electron cli.

This was referenced Oct 17, 2022
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 17, 2022

I have automatically backported this PR to "20-x-y", please check out #36048

@trop trop bot mentioned this pull request Oct 17, 2022
Merged
@trop trop bot removed the target/20-x-y label Oct 17, 2022
@trop
Copy link
Contributor

trop bot commented Oct 17, 2022

I have automatically backported this PR to "22-x-y", please check out #36049

@trop
Copy link
Contributor

trop bot commented Oct 17, 2022

I have automatically backported this PR to "21-x-y", please check out #36050

@trop trop bot added in-flight/22-x-y merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. target/21-x-y PR should also be added to the "21-x-y" branch. in-flight/21-x-y labels Oct 17, 2022
@trop trop bot removed the in-flight/20-x-y label Oct 17, 2022
@Henry78 Henry78 mentioned this pull request Nov 24, 2022
Closed
3 tasks
@commit-lint commit-lint bot mentioned this pull request Feb 9, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@Piroro-hs @khalwa
fix: override app's desktop name and v8 flags in default-app (electro…
d38b2a2 
…n#35997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: V8 flags and desktop name in package.json does not hornored when running local app using electron cli
4 participants
@Piroro-hs @zcbenz @MarshallOfSound @codebytere