fix: drag and drop should copy on macOS #35963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
zcbenz
approved these changes
Oct 11, 2022
|
Release Notes Persisted
|
trop bot
added a commit
that referenced
this pull request
Oct 11, 2022
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop bot
added a commit
that referenced
this pull request
Oct 11, 2022
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop bot
added a commit
that referenced
this pull request
Oct 11, 2022
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This was referenced Oct 11, 2022
|
I have automatically backported this PR to "22-x-y", please check out #35976 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "21-x-y", please check out #35977 |
|
I have automatically backported this PR to "20-x-y", please check out #35978 |
trop
bot
added
in-flight/20-x-y
and removed
target/21-x-y
trop
bot
added
merged/22-x-y
codebytere
added a commit
that referenced
this pull request
Oct 11, 2022
fix: drag and drop should copy on macOS (#35963) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
jkleinsc
pushed a commit
that referenced
this pull request
Oct 12, 2022
fix: drag and drop should copy on macOS (#35963) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop
bot
added
merged/21-x-y
jkleinsc
pushed a commit
that referenced
this pull request
Oct 12, 2022
fix: drag and drop should copy on macOS (#35963) Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35264.
Inadvertently introduced by #34615, which set the drag behavior to
NSDragOperationEvery. We instead want to copy when the user is moving an item outside the app (e.g. to the desktop) and infer behavior within the application context, as was the previous behavior.Checklist
npm testpassesRelease Notes
Notes: Fixed a drag-and-drop issue on macOS where items would be incorrectly moved instead of copied in some contexts.