fix: override content::ContentMainDelegate::CreateContentClient()
#35932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
jkleinsc
approved these changes
Oct 6, 2022
nornagon
approved these changes
Oct 6, 2022
MarshallOfSound
approved these changes
Oct 6, 2022
|
Release Notes Persisted
|
|
I was unable to backport this PR to "20-x-y" cleanly; |
This was referenced Oct 10, 2022
|
I have automatically backported this PR to "22-x-y", please check out #35964 |
trop
bot
added
in-flight/22-x-y
and removed
target/22-x-y
|
I have automatically backported this PR to "21-x-y", please check out #35965 |
trop
bot
added
in-flight/21-x-y
and removed
target/21-x-y
trop
bot
added
merged/21-x-y
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #35916.
Overrides
content::ContentMainDelegate::CreateContentClient()to prevent duplicate creation. The previous code was added in Electron's infancy, and the override did not become available until 2019, which is why this hasn't yet been changed.Checklist
npm testpassesRelease Notes
Notes: Fixed a potential memory leak.