fix: only override valid electron module names

[MarshallOfSound]

Fixes #33014

Notes: Doing require('electron/*') where * is not one of main, common or renderer no longer resolves with the built-in electron module

[release-clerk]

Release Notes Persisted

Doing require('electron/*') where * is not one of main, common or renderer no longer resolves with the built-in electron module

[RaisinTen]

@MarshallOfSound thanks for the PR! While this does fix the issue for arbitrary suffixes after electron/, things like electron/main, electron/common and electron/renderer are still requirable in userland. I'm not sure what those modules are for because internally these are still loading electron -

electron/lib/common/reset-search-paths.ts

Line 40 in e1494dd

get: () => require('electron')

. Should those be disallowed too or are those there for a reason we should document?
It also feels a little unexpected that we can do require('electron/renderer') in the main process given that we have -

electron/lib/common/reset-search-paths.ts

Lines 47 to 52 in e1494dd

	if (process.type === 'browser') {
	makeElectronModule('electron/main');
	}
	if (process.type === 'renderer') {
	makeElectronModule('electron/renderer');
	}

.

[MarshallOfSound]

@RaisinTen those module aliases are for typescript purposes.

The types for electron/main consist of only main process modules, etc.

It is intentional they work everywhere, they're superficial for TS only.