fix: potential exception when calling webFrameMainBinding.fromIdOrNull() #35803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
2 tasks
trop
bot
added
21-x-y
backport
miniak
approved these changes
Sep 24, 2022
miniak
force-pushed
the
trop/21-x-y-bp-fix-potential-exception-when-calling-webframemainbinding-fromidornull--1664047159470
branch
from
9aea146
to
f5c4fe8
Compare
VerteDinde
approved these changes
Sep 26, 2022
|
Not sure why artifact comparison is failing here, looks like a 503 from the yarn registry and not anything related to changes 🤔 Given all other checks are green, I'm going to merge |
VerteDinde
deleted the
trop/21-x-y-bp-fix-potential-exception-when-calling-webframemainbinding-fromidornull--1664047159470
branch
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35785
See that PR for details.
Notes: none