Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add app.getSystemLocale() method #35794

Merged
merged 13 commits into from Sep 26, 2022
Merged

feat: add app.getSystemLocale() method #35794

merged 13 commits into from Sep 26, 2022

Commits on Sep 23, 2022

  1. feat: add app.getSystemLocale() method

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    a7f79ca View commit details
    Browse the repository at this point in the history

  2. Update shell/browser/electron_browser_main_parts.cc 

    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    @rzhao271 @ckerr @electron-bot
    2 people authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    c521650 View commit details
    Browse the repository at this point in the history

  3. Change methods to be const

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    3017061 View commit details
    Browse the repository at this point in the history

  4. Apply PR feedback

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    df5bb09 View commit details
    Browse the repository at this point in the history

  5. Fix mac compile

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    098a53f View commit details
    Browse the repository at this point in the history

  6. Add missing scope

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    6860971 View commit details
    Browse the repository at this point in the history

  7. Apply style changes

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    1f974cd View commit details
    Browse the repository at this point in the history

  8. Change note

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    598086c View commit details
    Browse the repository at this point in the history

  9. Add braces to get the comment indentation right

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    4f361f9 View commit details
    Browse the repository at this point in the history

  10. Change to static

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    f37e0ae View commit details
    Browse the repository at this point in the history

  11. Apply PR feedback

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    78eccb5 View commit details
    Browse the repository at this point in the history

  12. Fix the documentation

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9bd6561 View commit details
    Browse the repository at this point in the history

  13. Remove extraneous file

    @rzhao271 @electron-bot
    rzhao271 authored and electron-bot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    04c02cf View commit details
    Browse the repository at this point in the history