Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uv_os_gethostname failing on Windows 7 (libuv patch regression) #35702

Merged
merged 1 commit into from Sep 16, 2022
Merged

fix: uv_os_gethostname failing on Windows 7 (libuv patch regression) #35702

merged 1 commit into from Sep 16, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 16, 2022 •
edited

Description of Change

Fixes #35219. Regressed in a2e5d19

Checklist

Release Notes

Notes: Fixed uv_os_gethostname failing on Windows 7

@miniak miniak requested review from a team as code owners September 16, 2022 02:17
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 16, 2022
@miniak miniak self-assigned this Sep 16, 2022
@miniak miniak added semver/patch backwards-compatible bug fixes target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Sep 16, 2022
@miniak miniak force-pushed the miniak/fix_crash_caused_by_gethostnamew_on_windows_7 branch from 6f6b402 to cf48ca0 Compare September 16, 2022 02:20
@miniak miniak changed the title fix: crash caused by GetHostNameW on Windows 7 (fix patch regression) fix: uv_os_gethostname failing on Windows 7 (libuv patch regression) Sep 16, 2022
@miniak miniak mentioned this pull request Sep 16, 2022
Closed
3 tasks
@miniak miniak force-pushed the miniak/fix_crash_caused_by_gethostnamew_on_windows_7 branch from cf48ca0 to 2dd42ab Compare September 16, 2022 02:30
@deepak1556 deepak1556 merged commit 7d3f22d into main Sep 16, 2022
@deepak1556 deepak1556 deleted the miniak/fix_crash_caused_by_gethostnamew_on_windows_7 branch September 16, 2022 05:33
@release-clerk
Copy link

release-clerk bot commented Sep 16, 2022

Release Notes Persisted

Fixed uv_os_gethostname failing on Windows 7

This was referenced Sep 16, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Sep 16, 2022

I have automatically backported this PR to "19-x-y", please check out #35703

@trop
Copy link
Contributor

trop bot commented Sep 16, 2022

I have automatically backported this PR to "21-x-y", please check out #35704

@trop
Copy link
Contributor

trop bot commented Sep 16, 2022

I have automatically backported this PR to "20-x-y", please check out #35705

@trop trop bot added in-flight/20-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. target/20-x-y labels Sep 16, 2022
@lorand-horvath
Copy link

@miniak If I could, I would give you $100 right now, for fixing this.
And low and behold, it's a simple one-liner, as it usually proves to be.

THANK YOU

@lorand-horvath lorand-horvath mentioned this pull request Sep 16, 2022
Closed
3 tasks
@trop trop bot added merged/19-x-y merged/21-x-y PR was merged to the "21-x-y" branch. and removed in-flight/19-x-y labels Sep 16, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 19, 2022
@zbyna zbyna mentioned this pull request Sep 27, 2022
Closed
@lorand-horvath lorand-horvath mentioned this pull request Oct 21, 2022
Closed
@lorand-horvath lorand-horvath mentioned this pull request Nov 10, 2022
Open
@commit-lint commit-lint bot mentioned this pull request Jan 11, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
fix: uv_os_gethostname failing on Windows 7 (libuv patch regression) (e…
5f6a213 
…lectron#35702)

Co-authored-by: Milan Burda <miburda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Win7 can't open electron app after upgrade to v19.x.x
4 participants
@miniak @lorand-horvath @deepak1556 @codebytere