feat: allow custom v8 snapshots to be used in the main process and the default snapshot in the renderer process #35695
Conversation
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
trop
bot
added
21-x-y
backport
|
@ckerr and @codebytere, I'm new to the patch back process. Is there anything that I need to do to get this in? Or will someone from your end take care of what needs to be taken care of? Thanks! |
|
@ryanthemanuel Backports just need to be approved by our Releases WG, which yours was yesterday! Would you mind rebasing this PR against latest 21-x-y, in order to kick off CircleCI? 🙂 |
|
Hi @VerteDinde thanks for the approval. I'd update the branch, but I don't have write privs to the repo. |
…e default snapshot in the renderer process (#35266) * Updates to allow for using a custom v8 snapshot file name * Allow using a custom v8 snapshot file name * Fix up patch due to merge * Use fuse to set up custom v8 snapshot file in browser process * Refactor to use delegate instead of command line parameter * Refactoring * Update due to merge * PR comments * Rename patch * Rename patch
VerteDinde
force-pushed
the
trop/21-x-y-bp-feat-allow-custom-v8-snapshots-to-be-used-in-the-main-process-and-the-default-snapshot-in-the-renderer-process-1663273306165
branch
from
aeec599
to
55f7404
Compare
VerteDinde
deleted the
trop/21-x-y-bp-feat-allow-custom-v8-snapshots-to-be-used-in-the-main-process-and-the-default-snapshot-in-the-renderer-process-1663273306165
branch
|
Release Notes Persisted
|
|
@ryanthemanuel Done - thanks again for this fix, it's very appreciated! 🙇♀️ |
Backport of #35266
See that PR for details.
Notes: Added
LoadBrowserProcessSpecificV8Snapshotas a new fuse that will let the main/browser process load its v8 snapshot from a file atbrowser_v8_context_snapshot.bin. Any other process will use the same path as is used today.