feat: allow custom v8 snapshots to be used in the main process and the default snapshot in the renderer process #35694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
5 tasks
trop
bot
added
20-x-y
backport
…e default snapshot in the renderer process (#35266) * Updates to allow for using a custom v8 snapshot file name * Allow using a custom v8 snapshot file name * Fix up patch due to merge * Use fuse to set up custom v8 snapshot file in browser process * Refactor to use delegate instead of command line parameter * Refactoring * Update due to merge * PR comments * Rename patch * Rename patch chore: update patches
jkleinsc
force-pushed
the
trop/20-x-y-bp-feat-allow-custom-v8-snapshots-to-be-used-in-the-main-process-and-the-default-snapshot-in-the-renderer-process-1663273303061
branch
from
d776da2
to
caa63db
Compare
VerteDinde
approved these changes
Sep 22, 2022
VerteDinde
deleted the
trop/20-x-y-bp-feat-allow-custom-v8-snapshots-to-be-used-in-the-main-process-and-the-default-snapshot-in-the-renderer-process-1663273303061
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35266
See that PR for details.
Notes: Added
LoadBrowserProcessSpecificV8Snapshotas a new fuse that will let the main/browser process load its v8 snapshot from a file atbrowser_v8_context_snapshot.bin. Any other process will use the same path as is used today.